Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

boolean_mask_assign with start_axis #16886

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Nov 22, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 self-assigned this Nov 22, 2019
@haojin2 haojin2 added the Numpy label Nov 22, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Nov 22, 2019
@haojin2 haojin2 force-pushed the np_boolean_mask_assign_start_axis branch 6 times, most recently from d81f629 to 5a5cd9e Compare November 27, 2019 00:55
@haojin2 haojin2 force-pushed the np_boolean_mask_assign_start_axis branch from 5a5cd9e to d9616f2 Compare December 6, 2019 08:36
@haojin2 haojin2 changed the title [DO NOT MERGE] [DO NOT REVIEW] boolean_mask_assign with start_axis boolean_mask_assign with start_axis Dec 6, 2019
@reminisce reminisce merged commit 82c34ee into apache:master Dec 7, 2019
numpy automation moved this from In progress to Done Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants