Enforces NDArray type in get_symbol #16871

Kh4L · 2019-11-20T13:45:30Z

Description

Giving a Python object different than NDArray to get_symbol causes a Segfault, we need to enforce the type.
Add an assert for type checking.

Changes are complete (i.e. I finished coding on this PR)
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

ptrendx · 2019-11-20T18:35:22Z

Could you make the error message a little bit more clear (like adding "Incorrect type of the argument" or something like that?)

Kh4L · 2019-11-20T18:45:08Z

Could you make the error message a little bit more clear (like adding "Incorrect type of the argument" or something like that?)

Done

Signed-off-by: Serge Panev <[email protected]>

ptrendx

LGTM

Kh4L requested a review from szha as a code owner November 20, 2019 13:45

Kh4L force-pushed the get_symbol_type_check branch from eed2355 to f4adaa9 Compare November 20, 2019 18:44

Enforces NDArray type in get_symbol

ffce8bf

Signed-off-by: Serge Panev <[email protected]>

Kh4L force-pushed the get_symbol_type_check branch from f4adaa9 to ffce8bf Compare November 20, 2019 19:07

ptrendx approved these changes Nov 20, 2019

View reviewed changes

ptrendx merged commit 95c3d03 into apache:master Nov 20, 2019