Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix a few np issues #16849

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Fix a few np issues #16849

merged 2 commits into from
Nov 20, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Nov 19, 2019

Description

Fix #16616, #16413 and adding np.shape operator to imperative mode.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@haojin2 haojin2 added the Numpy label Nov 19, 2019
@haojin2 haojin2 requested a review from szha as a code owner November 19, 2019 06:34
@haojin2 haojin2 self-assigned this Nov 19, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Nov 19, 2019
@haojin2 haojin2 force-pushed the fix_np_issues branch 2 times, most recently from 0d97eae to 4b553f1 Compare November 19, 2019 07:35
@haojin2 haojin2 added the R1.6.0 label Nov 20, 2019
numpy automation moved this from In progress to Reviewer approved Nov 20, 2019
@reminisce reminisce merged commit f1c6880 into apache:master Nov 20, 2019
numpy automation moved this from Reviewer approved to Done Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

[Flaky] test_numpy_op.test_np_einsum
2 participants