Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] Fix expand_dims fall back #16837

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

wuxun-zhang
Copy link
Contributor

Description

Should fix 16833
@pengzhao-intel @ZhennanQin @TaoLv @reminisce

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Nov 16, 2019
@pengzhao-intel pengzhao-intel merged commit 69fd018 into apache:master Nov 16, 2019
CPU Performance and Quantization automation moved this from In progress to Done Nov 16, 2019
@TaoLv
Copy link
Member

TaoLv commented Nov 16, 2019

@reminisce @wuxun-zhang @pengzhao-intel Do think we need pick this fix to v1.6.x?

@pengzhao-intel
Copy link
Contributor

@wuxun-zhang please file a PR to cherry-pick this PR into 1.6?

wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Nov 18, 2019
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Nov 18, 2019
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Nov 20, 2019
@haojin2 haojin2 added the R1.6.0 label Nov 20, 2019
pengzhao-intel pushed a commit that referenced this pull request Nov 22, 2019
* fix expand_dims fall back when input's ndim is 0 (#16837)

* rebase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Numpy] expands_dims cannot suport scalar
4 participants