Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Fix] Add ctx to the original ndarray and revise the usage of context to ctx #16819

Merged
merged 3 commits into from
Nov 15, 2019

Conversation

sxjscience
Copy link
Member

In the numpy interface, context has been renamed to be ctx. I've added the ctx back to the original ndarray and also revised the .context calls.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

try to fix warning

try to fix all warnings

use ctx
@sxjscience sxjscience changed the title [Fix] Try to fix all warnings [Fix] Add ctx to the original ndarray and revise the usage of context to ctx Nov 15, 2019
@sxjscience sxjscience merged commit 4a27b5c into apache:master Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants