Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add op bitwise_or [numpy] #16801

Merged
merged 6 commits into from
Nov 21, 2019
Merged

add op bitwise_or [numpy] #16801

merged 6 commits into from
Nov 21, 2019

Conversation

Yiyan66
Copy link
Contributor

@Yiyan66 Yiyan66 commented Nov 13, 2019

Description

add op bitwise_or

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Yiyan66 Yiyan66 requested a review from szha as a code owner November 13, 2019 09:26
@hgt312
Copy link
Contributor

hgt312 commented Nov 13, 2019

@mxnet-label-bot add [Numpy]

Copy link
Contributor

@hgt312 hgt312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing addition of dispatch protocol.

python/mxnet/ndarray/numpy/_op.py Outdated Show resolved Hide resolved
python/mxnet/ndarray/numpy/_op.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/symbol/numpy/_symbol.py Outdated Show resolved Hide resolved
python/mxnet/symbol/numpy/_symbol.py Outdated Show resolved Hide resolved
@Yiyan66 Yiyan66 force-pushed the master branch 2 times, most recently from 58ed7ae to 57e27c4 Compare November 19, 2019 11:52
src/operator/mshadow_op.h Outdated Show resolved Hide resolved
@haojin2
Copy link
Contributor

haojin2 commented Nov 19, 2019

Please address the comments and get rid of the change of tvm submodule.

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 4da14a2 into apache:master Nov 21, 2019
@haojin2 haojin2 mentioned this pull request Dec 10, 2019
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants