Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Add NumPy support for np.linalg.det and np.linalg.slogdet #16800

Merged
merged 16 commits into from
Nov 24, 2019
Merged

[Numpy] Add NumPy support for np.linalg.det and np.linalg.slogdet #16800

merged 16 commits into from
Nov 24, 2019

Conversation

vexilligera
Copy link
Contributor

@vexilligera vexilligera commented Nov 13, 2019

Description

The flakiness in #16415 was caused by a typo in LaOpDetBackward, which resulted in array index out of bound. The reason it only happened on Windows and was susceptible to the presence of call to broadcast in slogdet_backward may have something to do with the Windows Release image stack memory layout. I guess the Linux binary was simply a bit more tolerant.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vexilligera vexilligera changed the title [WIP][Numpy] np.linalg.det and np.linalg.slogdet [WIP][DO NOT MERGE][Numpy] np.linalg.det and np.linalg.slogdet Nov 13, 2019
@hgt312
Copy link
Contributor

hgt312 commented Nov 13, 2019

@mxnet-label-bot add [Numpy]

@vexilligera vexilligera changed the title [WIP][DO NOT MERGE][Numpy] np.linalg.det and np.linalg.slogdet [Numpy] Add NumPy support for np.linalg.det and np.linalg.slogdet Nov 15, 2019
@vexilligera
Copy link
Contributor Author

@reminisce @haojin2

src/operator/tensor/la_op.h Outdated Show resolved Hide resolved
src/operator/tensor/la_op-inl.h Outdated Show resolved Hide resolved
@reminisce reminisce merged commit 11edb70 into apache:master Nov 24, 2019
@vexilligera vexilligera deleted the det branch November 25, 2019 03:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants