This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add support for boolean inputs to FusedOp #16796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
reviewed
Nov 12, 2019
sxjscience
reviewed
Nov 21, 2019
|
@marcoabreu @larroy Could you tell me what is the configuration of the unix-gpu test runners? They make TVM error out and I cannot reproduce it locally. |
7 tasks
|
@sxjscience Could you validate the fix in your original code? |
|
@ptrendx I'm testing it locally |
|
@ptrendx Thanks for the fix. I've confirmed that it solves my previous failure. |
sxjscience
approved these changes
Nov 23, 2019
ptrendx
added a commit
to ptrendx/mxnet
that referenced
this pull request
Nov 23, 2019
* Support bool in fusion * Added tests * Use use_np decorator vs calling the numpy convention by hand * Debug TVM failure * Fix * Do not invoke TVM broadcast kernel
ptrendx
added a commit
that referenced
this pull request
Nov 23, 2019
|
@ptrendx is in the container in ci/ folder. You can use the exact same run by using ci/build.py you have the same instruction in the output of CI run either at the top or the bottom. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16723
This PR fixes 2 problems:
This PR fixes both of those problems and introduces tests for them.
@sxjscience Please validate the fix.