Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add OP diag [numpy] #16786

Merged
merged 11 commits into from
Nov 18, 2019
Merged

Add OP diag [numpy] #16786

merged 11 commits into from
Nov 18, 2019

Conversation

Tommliu
Copy link
Contributor

@Tommliu Tommliu commented Nov 12, 2019

Description

Add op diag

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner November 12, 2019 07:26
@hgt312
Copy link
Contributor

hgt312 commented Nov 12, 2019

@mxnet-label-bot add [Numpy]

Copy link
Contributor

@hgt312 hgt312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do not change submodules. Besides, use your master branch is not recommended.

tests/python/unittest/test_numpy_op.py Show resolved Hide resolved
python/mxnet/_numpy_op_doc.py Show resolved Hide resolved
@haojin2
Copy link
Contributor

haojin2 commented Nov 14, 2019

Why r u also updating dmlc-core?

index_t dsize,
const int &k,
mxnet_op::Stream<xpu> *s,
const std::vector<OpReqType> &req) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I suggested last time, simply pass the OpReqType value instead of the whole vector.

[0, 0, 8]])
"""
pass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this blank line.

@haojin2 haojin2 merged commit 135c42c into apache:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants