Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Fix linalg.inv test flakiness #16782

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[Numpy] Fix linalg.inv test flakiness #16782

merged 1 commit into from
Nov 12, 2019

Conversation

vexilligera
Copy link
Contributor

Description

(Brief description on what this PR is about)
Fix inv test flakiness using random matrices generated by SVD

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vexilligera vexilligera changed the title [Numpy] Fix inv test flakiness [Numpy] Fix linalg.inv test flakiness Nov 12, 2019
@vexilligera
Copy link
Contributor Author

vexilligera commented Nov 12, 2019

@reminisce @haojin2

@hgt312
Copy link
Contributor

hgt312 commented Nov 12, 2019

@mxnet-label-bot add [Numpy]

@reminisce reminisce merged commit b9b56e6 into apache:master Nov 12, 2019
@vexilligera vexilligera deleted the inv_test branch November 13, 2019 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants