Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[docs] Fix runtime feature detection documentation #16746

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Nov 7, 2019

Description

as title.

Documentation was not appearing in the index nor sidebar.
Adds usage example to mxnet.runtime

@ThomasDelteil @aaronmarkham

Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also somehow expose USE_CPP_PACKAGE
runtime features currently doesn't track those flags.

Don't want to block otherwise. LGTM!

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@larroy
Copy link
Contributor Author

larroy commented Nov 30, 2019

@aaronmarkham @zachgk @lanking520 can we merge this?

@zachgk zachgk merged commit 78a2523 into apache:master Dec 2, 2019
@larroy
Copy link
Contributor Author

larroy commented Dec 3, 2019

@ChaiBapchya does CPP affect the library build?

@aaronmarkham
Copy link
Contributor

@ChaiBapchya does CPP affect the library build?

You have to build from source with that flag in order to use CPP. You can't just take a lib you built without the flag and setup the binding (like you do with the other lang bindings)... if that's what you're asking... At least, this is my understanding.

@larroy
Copy link
Contributor Author

larroy commented Dec 3, 2019

That's a good call for contributions in that case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants