This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to change MKL-DNN library from dynamic linking to static linking. That will help:
There were other attempts to do so before. But before MKL-DNN v1.0 integrated, it also depends on libmklml_intel.so. So it doesn't make much sense if we only make MKL-DNN static linked and leave libmklml_intel.so outside.
This PR is also removing a python unit test which was designed to check MKL-DNN install by doing grep against the proc maps to make sure mkldnn.so is linked. After changing to static link, the approach would not work and not needed.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments