Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix requantize flaky test #16709

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Fix requantize flaky test #16709

merged 3 commits into from
Nov 5, 2019

Conversation

xinyu-intel
Copy link
Contributor

Description

Fixes #11747
@pengzhao-intel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

pengzhao-intel
pengzhao-intel approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Nov 4, 2019
@xinyu-intel xinyu-intel changed the title [WIP] Fix requantize flaky test Fix requantize flaky test Nov 4, 2019
@pengzhao-intel pengzhao-intel merged commit c583e44 into apache:master Nov 5, 2019
CPU Performance and Quantization automation moved this from In progress to Done Nov 5, 2019
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@xinyu-intel @yajiedesign
fix requantize flaky test (apache#16709)
54faba0
@zixuanweeei zixuanweeei mentioned this pull request Apr 10, 2020
Closed
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Apr 10, 2020
@xinyu-intel @ChaiBapchya
fix requantize flaky test (apache#16709)
636fb6c
@leezu leezu mentioned this pull request Apr 10, 2020
Merged
leezu pushed a commit that referenced this pull request Apr 10, 2020
@ChaiBapchya @xinyu-intel
[R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6…
3ba1751 
….x (#17993)

* fix R error; backport 1 line from #17228

* print exception

* remove namespace to resolve load_module not found error

* fix static build ubuntu 1404 python error in nvidia docker gnutls handshake error

* fix rvm version error

* fix requantize flaky test (#16709)

Co-authored-by: Xinyu Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

Assignees
No one assigned
Labels
MKLDNN
Projects
No open projects
CPU Performance and Quantization
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test test_quantization_mkldnn.test_requantize_int32_to_int8
2 participants
@xinyu-intel @pengzhao-intel