Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Quantization] Enhance gluon quantization API #16695

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

wuxun-zhang
Copy link
Contributor

Description

This PR is to improve the gluon quantize API, including below changes:

  • fixed when input's ndim is larger than 4 -> GluonCV PR#1000
  • exposed quantize_mode to quantize_net function explicitly

@pengzhao-intel @ZhennanQin @xinyu-intel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Nov 1, 2019
Copy link
Contributor

@xinyu-intel xinyu-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add quantized_mode in quantize_model_mkldnn

CPU Performance and Quantization automation moved this from In progress to Review in progress Nov 1, 2019
@pengzhao-intel
Copy link
Contributor

@xinyu-intel @ZhennanQin please take a review

CPU Performance and Quantization automation moved this from Review in progress to Reviewer approved Nov 4, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel merged commit 94aab39 into apache:master Nov 4, 2019
CPU Performance and Quantization automation moved this from Reviewer approved to Done Nov 4, 2019
@wuxun-zhang wuxun-zhang deleted the enhance_gluon_quantize branch November 4, 2019 08:57
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
* enhance gluon quantization API

* add quantize_mode into quantize_model_mkldnn function

* fix lint

* rebase code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants