Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Scala][Clojure] change confusing native jar loading message #16626

Conversation

gigasquid
Copy link
Member

Description

This PR address feedback in the issue #13108

This warning is confusing and alarming to new users of the Clojure package. This PR changes the log level to info and the messaging to better reflect that the normal action is to extract, copy, and load the native dependencies from the jar.

New output will be :

INFO  MXNetJVM: Try loading mxnet-scala from native path.
INFO  MXNetJVM: Copying and loading native library from the jar archive
INFO  org.apache.mxnet.util.NativeLibraryLoader: Replaced .dylib with .jnilib

as opposed to the old output of

INFO  MXNetJVM: Try loading mxnet-scala from native path.
INFO  MXNetJVM: Try loading mxnet-scala-linux-x86_64-gpu from native path.
INFO  MXNetJVM: Try loading mxnet-scala-linux-x86_64-cpu from native path.
WARN  MXNetJVM: MXNet Scala native library not found in path. Copying native library from the archive. Consider installing the library somewhere in the path (for Windows: PATH, for Linux: LD_LIBRARY_PATH), or specifying by Java cmd option -Djava.library.path=[lib path].
INFO  org.apache.mxnet.util.NativeLibraryLoader: Loading libmxnet-scala.so from /lib/native/ copying to mxnet-scala

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu
Copy link
Contributor

Hey, do you mind rebasing?

@gigasquid
Copy link
Member Author

Thanks - yes - I'll rebase :)

@gigasquid gigasquid force-pushed the change-warning-on-base-loading-of-scala-native branch from a0dd544 to 2533bd6 Compare November 1, 2019 17:28
@gigasquid gigasquid merged commit be92cc6 into apache:master Nov 2, 2019
@gigasquid gigasquid deleted the change-warning-on-base-loading-of-scala-native branch November 2, 2019 18:29
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants