Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add API docs to INT64 APIs #16617

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Add API docs to INT64 APIs #16617

merged 2 commits into from
Jan 22, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Oct 25, 2019 •
edited
Loading

Description

Title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • M src/c_api/c_api_symbolic.cc

Comments

Found lots of other functions (APIs) in c_api.cc and c_api_symbolic.cc not have API docs.

@access2rohit
Copy link
Contributor

access2rohit commented Jan 21, 2020 •
edited
Loading

Can you make you comments similar to these for consistency:
https://github.com/apache/incubator-mxnet/blob/master/include/mxnet/c_api.h#L587-L621

access2rohit
access2rohit approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@access2rohit
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 22, 2020
@apeforest apeforest merged commit 32d3bd8 into apache:master Jan 22, 2020
@ChaiBapchya ChaiBapchya deleted the api_fix branch January 22, 2020 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apeforest apeforest apeforest approved these changes

@access2rohit access2rohit access2rohit approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChaiBapchya @access2rohit @apeforest @lanking520