Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[NumPy][Operator] NumPy operator may_share_memory and shares_memory #16533

Merged
merged 4 commits into from
Oct 28, 2019
Merged

[NumPy][Operator] NumPy operator may_share_memory and shares_memory #16533

merged 4 commits into from
Oct 28, 2019

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Oct 18, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@hgt312 hgt312 requested a review from szha as a code owner October 18, 2019 10:36
@reminisce reminisce added this to In progress in numpy via automation Oct 20, 2019
@hgt312 hgt312 force-pushed the np_op_memory branch 4 times, most recently from c1aa095 to 380bf03 Compare October 22, 2019 05:44
@hgt312 hgt312 changed the title [WIP][NumPy][Operator] NumPy operator may_share_memory and shares_memory [NumPy][Operator] NumPy operator may_share_memory and shares_memory Oct 23, 2019
@hgt312 hgt312 force-pushed the np_op_memory branch 2 times, most recently from 3bb21b1 to ab5d6e4 Compare October 25, 2019 05:52
numpy automation moved this from In progress to Reviewer approved Oct 28, 2019
haojin2
haojin2 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 86ed5f5 into apache:master Oct 28, 2019
numpy automation moved this from Reviewer approved to Done Oct 28, 2019
@hgt312 hgt312 deleted the np_op_memory branch October 28, 2019 08:39
@larroy larroy mentioned this pull request Oct 30, 2019
Open
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@hgt312 @yajiedesign
[NumPy][Operator] NumPy operator may_share_memory and `shares_memor…
e2c924b 
…y` (apache#16533)

* init

* finish & fix bug of 'take'

* fix bug

* add dispatch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hgt312 @haojin2 @reminisce