Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy compatible vsplit; minor change to numpy split #15983

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

zoeygxy
Copy link
Contributor

@zoeygxy zoeygxy commented Aug 23, 2019

Description

Added python list and set as supported types for parameter 'indices_or_sections'
Added python frontend support for numpy.vsplit

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added python list and set as supported types for parameter 'indices_or_sections'
  • Added python frontend support for numpy.vsplit

Comments

  • Note: numpy.split and numpy.vsplit still does not support type ndarray for parameter 'indices_or_sections'.

@zoeygxy
Copy link
Contributor Author

zoeygxy commented Aug 23, 2019

@haojin2

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 changed the base branch from master to numpy_pr_merge October 12, 2019 23:22
@haojin2 haojin2 merged commit 4b535a8 into apache:numpy_pr_merge Oct 13, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants