Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy-compatible concatenate upstream #15894

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Aug 14, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Numpy-compatible concatenate
  • Unit tests

Comments

Same as #15843

@haojin2 haojin2 added the Numpy label Aug 14, 2019
@haojin2 haojin2 requested a review from reminisce August 14, 2019 22:31
@haojin2 haojin2 requested a review from szha as a code owner August 14, 2019 22:31
@haojin2 haojin2 self-assigned this Aug 14, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Aug 14, 2019
numpy automation moved this from In progress to Reviewer approved Aug 14, 2019
@reminisce reminisce merged commit 9dbfc2d into apache:master Aug 15, 2019
numpy automation moved this from Reviewer approved to Done Aug 15, 2019
xiezhq-hermann pushed a commit to xiezhq-hermann/incubator-mxnet that referenced this pull request Aug 15, 2019
* numpy-compatible concatenate upstream

* extend ci deadline
xiezhq-hermann pushed a commit to xiezhq-hermann/incubator-mxnet that referenced this pull request Aug 15, 2019
* numpy-compatible concatenate upstream

* extend ci deadline
xiezhq-hermann pushed a commit to xiezhq-hermann/incubator-mxnet that referenced this pull request Aug 15, 2019
* numpy-compatible concatenate upstream

* extend ci deadline
marcoabreu added a commit that referenced this pull request Aug 20, 2019
@@ -21,7 +21,7 @@
// See documents at https://jenkins.io/doc/book/pipeline/jenkinsfile/

// timeout in minutes
max_time = 180
max_time = 240
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wasn't this discussed before? Sneaking this change here is not ok, this should go in a separate PR and clearly marked as such.

@haojin2 haojin2 deleted the np_concatenate_master branch August 20, 2019 18:29
larroy added a commit to larroy/mxnet that referenced this pull request Aug 20, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* numpy-compatible concatenate upstream

* extend ci deadline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants