This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
some minor typos/clarifications #15538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiBapchya
suggested changes
Jul 15, 2019
|
|
||
| For nightly build in CI, a snapshot build will be uploaded to apache repository with follow command: | ||
| For nightly builds (typically done by CI), a snapshot build will be uploaded to an apache snapshot repository with the following command: |
There was a problem hiding this comment.
Suggested change
| For nightly builds (typically done by CI), a snapshot build will be uploaded to an apache snapshot repository with the following command: | |
| For nightly builds (typically done by CI), a snapshot build will be uploaded to an Apache snapshot repository with the following command: |
|
|
||
| ```bash | ||
| cd scala-package | ||
| mvn deploy -Pnightly | ||
| ``` | ||
|
|
||
| Use following command to deploy release build (push artifacts to apache staging repository): | ||
| Use the following command when performing a release (pushes artifacts to an apache staging repository): |
There was a problem hiding this comment.
Previous statement was good enough, I guess (in terms of comprehensibility)
.
Suggested change
| Use the following command when performing a release (pushes artifacts to an apache staging repository): | |
| Use the following command when performing a release (pushes artifacts to an Apache staging repository): |
|
|
||
| Deploy to repository | ||
| -------------------- | ||
|
|
||
| By default, `maven deploy` will deploy artifacts to local file system, you can file then in: ``scala-package/deploy/target/repo`` folder. | ||
| By default, `maven deploy` will deploy artifacts to local file system, you can find them in the ``scala-package/deploy/target/repo`` folder. |
There was a problem hiding this comment.
Suggested change
| By default, `maven deploy` will deploy artifacts to local file system, you can find them in the ``scala-package/deploy/target/repo`` folder. | |
| By default, `maven deploy` will deploy artifacts to local file system. You can find them in the ``scala-package/deploy/target/repo`` folder. |
| @@ -133,8 +133,8 @@ Also, add the dependency which corresponds to your platform to the ```dependenci | |||
| Build From Source | |||
| ----------------- | |||
|
|
|||
| Checkout the [Installation Guide](http:https://mxnet.incubator.apache.org/install/index.html) contains instructions to install mxnet package and build it from source. Scala maven build assume you already have a ``lib/libmxnet.so`` file. | |||
| If you have built MXNet from source and are looking to setup Scala from that point, you may simply run the following from the MXNet source root, Scala build will detect your platform (OSX/Linux) and libmxnet.so flavor (CPU/GPU): | |||
| The [Installation Guide](http:https://mxnet.incubator.apache.org/install/index.html) contains instructions to install mxnet or build it from source. The Scala/Java package is built from source using Maven. The maven build assumes you already have a ``lib/libmxnet.so`` file. | |||
There was a problem hiding this comment.
Suggested change
| The [Installation Guide](http:https://mxnet.incubator.apache.org/install/index.html) contains instructions to install mxnet or build it from source. The Scala/Java package is built from source using Maven. The maven build assumes you already have a ``lib/libmxnet.so`` file. | |
| The [Installation Guide](http:https://mxnet.incubator.apache.org/install/index.html) contains instructions to install Mxnet or build it from source. The Scala/Java package is built from source using Maven. The maven build assumes you already have a ``lib/libmxnet.so`` file. |
|
@mxnet-label-bot add [Doc, Scala] |
aaronmarkham
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments