Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-978] Higher Order Gradient Support logp1, expm1, square. #15416

Conversation

kshitij12345
Copy link
Contributor

Description

PR intends to add support for higher order gradient for logp1, expm1, square.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA-978 issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • higher order gradient for a logp1, expm1, square.
  • unit test for the same.

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jul 1, 2019
@kshitij12345 kshitij12345 changed the title [MXNET-978] Higher Order Gradient Support logp1, expm1, square. [MXNET-978] Higher Order Gradient Support logp1, expm1, square Jul 16, 2019
@kshitij12345 kshitij12345 changed the title [MXNET-978] Higher Order Gradient Support logp1, expm1, square [MXNET-978] Higher Order Gradient Support logp1, expm1, square. Jul 16, 2019
@kshitij12345 kshitij12345 force-pushed the develop/add-higher-order/log1p-expm1-square branch from b4df92d to 14d6c5b Compare July 26, 2019 15:08
@karan6181
Copy link
Contributor

@kshitij12345 Could you please resolve the merge conflicts? Thanks

@kshitij12345
Copy link
Contributor Author

I guess we should wait till #15531 is in.

@kshitij12345
Copy link
Contributor Author

@apeforest @larroy @sxjscience
Gentle Ping for Review.

@sxjscience sxjscience merged commit f045018 into apache:master Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants