This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1415]Add MXEnginePushAsyncND and MXEnginePushSyncND C APIs #15177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, there.
In the PR #14615, @yuxihu added
Add MXEnginePushAsync
andMXEnginePushSync
C APIs.MXEnginePushAsync
andMXEnginePushSync
needsVarHandle
s ofNDArray
s.However, MXNet doesn't expose the API to get the VarHandle of a NDArray.
After the discussion with @szha, We considered that it's more elegant to add
MXEnginePushAsyncND
andMXEnginePushSyncND
C APIs, whose arguments areNDArrayHandle
s, rather thanVarHandle
s.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes