Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

rat check make target #15127

Merged
merged 1 commit into from
Jun 3, 2019
Merged

rat check make target #15127

merged 1 commit into from
Jun 3, 2019

Conversation

szha
Copy link
Member

@szha szha commented Jun 2, 2019

Description

rat check make target make ratcheck. resolves #14936

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • rat check make target make ratcheck

Comments

  • tested locally on osx

Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I have verified this make target works:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Creadur Rat 0.13-SNAPSHOT ................... SUCCESS [ 29.237 s]
[INFO] Apache Creadur Rat::API ............................ SUCCESS [  5.060 s]
[INFO] Apache Creadur Rat::Core ........................... SUCCESS [  3.027 s]
[INFO] Apache Creadur Rat::Plugin4Maven ................... SUCCESS [ 27.000 s]
[INFO] Apache Creadur Rat::Tasks4Ant ...................... SUCCESS [ 14.520 s]
[INFO] Apache Creadur Rat::Command Line 0.13-SNAPSHOT ..... SUCCESS [  5.845 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:27 min
[INFO] Finished at: 2019-06-03T11:50:15-07:00
[INFO] ------------------------------------------------------------------------
exec 5>&1; \
	RAT_JAR=build/rat/apache-rat/target/apache-rat-0.13-SNAPSHOT.jar; \
	OUTPUT=; \
    ERROR_MESSAGE="Printing headers for text files without a valid license header"; \
    echo "-------Process The Output-------"; \
    if [[ UTPUT =~ RROR_MESSAGE ]]; then \
        echo "ERROR: RAT Check detected files with unknown licenses. Please fix and run test again!"; \
        exit 1; \
    else \
        echo "SUCCESS: There are no files with an Unknown License."; \
    fi
-------Process The Output-------
SUCCESS: There are no files with an Unknown License

@eric-haibin-lin eric-haibin-lin merged commit 3ebd873 into apache:master Jun 3, 2019
@szha szha deleted the rat_check branch June 3, 2019 21:17
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a make target to run Apache Rat checks
3 participants