Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

move amp test and change op support to warning #15085

Merged
merged 1 commit into from
May 31, 2019
Merged

Conversation

szha
Copy link
Member

@szha szha commented May 28, 2019

Description

move amp test to follow naming convention for contrib features and change op support to warning

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • move test_amp to test_contrib_amp to follow the naming convention
  • change op support to warning instead of test failure.

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to wait for the result of the discussion on dev@ first

@szha
Copy link
Member Author

szha commented May 29, 2019

@marcoabreu I intended to wait until the discussion concludes too. Also, I'd like to remind you that vetos must be accompanied by technical justification https://www.apache.org/foundation/voting.html#Veto.

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Test]

@szha
Copy link
Member Author

szha commented May 31, 2019

met with @ptrendx today and we are proceeding with warning now.

@szha szha merged commit 294a34a into apache:master May 31, 2019
@szha szha deleted the amp_test branch May 31, 2019 04:30
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants