Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix gluon bi-rnn cell single step unroll #15081

Merged
merged 1 commit into from
May 30, 2019
Merged

fix gluon bi-rnn cell single step unroll #15081

merged 1 commit into from
May 30, 2019

Conversation

szha
Copy link
Member

@szha szha commented May 27, 2019

Description

fix gluon bi-rnn cell single step unroll bug. resolves #15062

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • fix gluon bi-rnn cell single step unroll

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Gluon, RNN]

Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix lgtm, however, I think we should mark the discrepancy between nd/sym operators

@szha
Copy link
Member Author

szha commented May 30, 2019

@zhreshold the issue is tracked in #9686

@szha szha merged commit 3143858 into apache:master May 30, 2019
@szha szha deleted the cell_rev branch May 30, 2019 22:34
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in BidirectionalCell for imperative mode when time_step is 1
4 participants