Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

NER example: fix divisions by zero #15068

Merged
merged 1 commit into from
May 28, 2019
Merged

Conversation

WilliamTambellini
Copy link
Contributor

Description

Prevents divisions by zero in the NER example

Checklist

Essentials

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • [ X ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • [ X ] fix divisions by zero in NER metrics

Comments

  • this change is not backward incompatible

@karan6181
Copy link
Contributor

@mxnet-label-bot add [Example, Python, pr-awaiting-review]

@marcoabreu marcoabreu added Example pr-awaiting-review PR is waiting for code review Python labels May 24, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit bbab527 into apache:master May 28, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
mikemwx pushed a commit to mikemwx/incubator-mxnet that referenced this pull request Jul 4, 2019
mikemwx pushed a commit to mikemwx/incubator-mxnet that referenced this pull request Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Example pr-awaiting-review PR is waiting for code review Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants