This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Rename np_compat to np_shape #15063
Merged
Rename np_compat to np_shape #15063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@mxnet-label-bot add [Numpy, pr-awaiting-review] |
yzhliu
approved these changes
May 24, 2019
szha
reviewed
May 25, 2019
python/mxnet/util.py
Outdated
|
|
||
| def set_np_shape(active): | ||
| """ | ||
| Turns on/off NumPy shape semantics. This is turned off by default for |
There was a problem hiding this comment.
document what numpy shape semantics means.
szha
reviewed
May 25, 2019
|
|
||
| def is_np_shape(): | ||
| """ | ||
| Checks whether the NumPy shape semantics is currently turned on. |
5 tasks
reminisce
force-pushed
the
rename_np_compat_to_np_shape
branch
from
6fe08c2
to
ba992c2
Compare
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Change np_compat to np_shape * Fix scala * Fix pylint * Add examples and fix documentation * Fix doc * More doc * Rename np_compat to np_shape in test_operatory.py * Rename in ndarray.cc
larroy
reviewed
Aug 21, 2019
| * \param prev returns the previous status before this set | ||
| * \return 0 when success, -1 when failure happens | ||
| */ | ||
| MXNET_DLL int MXSetIsNumpyCompatible(int is_np_comp, int* prev); | ||
| MXNET_DLL int MXSetIsNumpyShape(int is_np_shape, int* prev); |
There was a problem hiding this comment.
This changes how array format is expected when loading from disk. It would be good to document this on the function call. If NumpyShape is on, then Loading ndarray will fail. Just happened to me now. I think this is a side effect which should be clearly documented, or can we add additional arguments to Load with the different semantics?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames
np_compattonp_shapefor being more specific, since it only affects the shape inference logic. This needs to be merged to 1.5 release.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.