This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Safe LayerNorm #15002
Merged
Safe LayerNorm #15002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add[Operator, pr-work-in-progress] |
|
#14935 is merged. Can you resolve conflict? |
enable safe accumulation fix bug fix
|
@marcoabreu There's a weird sanity check error. The pylint check seems to have passed but it shows "Makefile:600: recipe for target 'pylint' failed". See http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-15002/5/pipeline/ |
eric-haibin-lin
approved these changes
May 22, 2019
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 22, 2019
* use float32 to store the reduction result of float16 enable safe accumulation fix bug fix * update test for safe_accumulate * fix
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* use float32 to store the reduction result of float16 enable safe accumulation fix bug fix * update test for safe_accumulate * fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continue #14699 . Requires #14935 to be merged.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
When the data input type is float16, we recommend to turn on the
MXNET_SAFE_ACCUMULATIONflag which not only improves precision but also accelerates the speed of the kernel.