This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Updates to cudnn package installation #14923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
perdasilva
force-pushed
the
cudnn_centos_install_fix
branch
2 times, most recently
from
55a882f
to
5c0cf00
Compare
|
@mxnet-label-bot add [pr-awaiting-review, CI] |
stu1130
approved these changes
May 9, 2019
ci/docker/install/centos7_cudnn.sh
Outdated
| @@ -22,11 +22,38 @@ | |||
|
|
|||
| set -ex | |||
|
|
|||
| if [ -z ${CUDA_VERSION} ]; then | |||
| echo "Error: CUDA_VERSION environment variable undefiend" | |||
ci/docker/install/centos7_cudnn.sh
Outdated
| fi | ||
|
|
||
| if [ -z ${CUDNN_VERSION} ]; then | ||
| echo "Error: CUDNN_VERSION environment variable undefiend" |
There was a problem hiding this comment.
Good eyes! It's fixed now.
perdasilva
force-pushed
the
cudnn_centos_install_fix
branch
from
5c0cf00
to
24e4fea
Compare
perdasilva
force-pushed
the
cudnn_centos_install_fix
branch
from
24e4fea
to
d5c3b0a
Compare
… will have the least impact on caching
perdasilva
changed the title
|
@marcoabreu please review in light of our discussion |
marcoabreu
approved these changes
May 10, 2019
|
Merged. Thank you! |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Generalizes centos7 cudnn download and install script * Updates setting of cudnn version to a position in the Dockerfile that will have the least impact on caching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the installation script for centos7 cudnn only installs a single version of cudnn independendly of what is set in the CUDNN_VERSION environment variable. This PR aims to fix it by making it more general by constructing the download url for the cudnn package from the CUDA_VERSION and CUDNN_VERSION environment variables.
Additionally, by having the CUDNN_VERSION defined at the start of the Dockerfile, the whole docker file will be rebuilt if there's a change. Therefore, moving it next to the call to the install cudnn script.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.