This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add cpu implementation for Deformable Convolution #14879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great Work! Thanks for your contribution! Could you please add a forward consistance check in https://github.com/apache/incubator-mxnet/blob/master/tests/python/gpu/test_operator_gpu.py ? Thank you! |
|
@mxnet-label-bot add [pr-awaiting-review] |
|
@wkcn Could you please review this PR once again? Thanks! |
wkcn
approved these changes
May 22, 2019
larroy
reviewed
May 22, 2019
| } | ||
| else { | ||
| h_high = h_low + 1; | ||
| } | ||
|
|
||
| if (w_low >= width - 1) { | ||
| w_high = w_low = width - 1; | ||
| w = (DType)w_low; | ||
| w = static_cast<DType>(w_low); |
| // num_axes should be smaller than block size | ||
| index_t num_spatial_axes = kernel_shape.ndim(); | ||
| int num_spatial_axes = kernel_shape.ndim(); |
larroy
reviewed
May 22, 2019
|
|
||
| if (h_low >= height - 1) { | ||
| h_high = height - 1; | ||
| h = static_cast<DType>(h_low); |
There was a problem hiding this comment.
Right, I'll look into the code in the perspective of overflow and change the type of int used in indexing and tensor size to index_t.
For int to float conversion, I think the overflow can't happens in float32 or float64.
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add cpu deformable_im2col * fix doc string * fix lint * add consistency check * fix code style * add cpu deformable_col2im, deformable_col2im_coord * update consistency test * unify variable names * fix lint * update to index_t
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cpu deformable_im2col implementation, also fix some errors in doc string.
Update:
The whole cpu part is implemented, and the code style is fixed to pass lint check.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments