Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve order of execution of install scripts. #14867

Merged
merged 2 commits into from
May 15, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented May 3, 2019

Description

Improve order of execution of install scripts.
Remove uneccesary environment variable. /usr/loca/lib already in ld.so.conf*

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy
Copy link
Contributor Author

larroy commented May 3, 2019

@mxnet-label-bot add [CI]

@marcoabreu marcoabreu added the CI label May 3, 2019
@larroy
Copy link
Contributor Author

larroy commented May 3, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label May 3, 2019
Remove uneccesary environment variable. /usr/loca/lib already in ld.so.conf*
@larroy
Copy link
Contributor Author

larroy commented May 15, 2019

@marcoabreu @perdasilva

@marcoabreu
Copy link
Contributor

Thanks a lot for catching that!

@marcoabreu marcoabreu merged commit 2ee7f4e into apache:master May 15, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Improve order of execution of install scripts.
Remove uneccesary environment variable. /usr/loca/lib already in ld.so.conf*

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants