Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix the return type of sparse.clip operator #14856

Merged
merged 4 commits into from
May 7, 2019
Merged

Fix the return type of sparse.clip operator #14856

merged 4 commits into from
May 7, 2019

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented May 1, 2019 •
edited
Loading

Description

Fixes #12787

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@apeforest @anirudh2290

eric-haibin-lin
eric-haibin-lin reviewed May 1, 2019
View reviewed changes
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Can we add an unit test?

@anirudhacharya
Copy link
Member Author

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 2, 2019
@wkcn wkcn merged commit 08895b7 into apache:master May 7, 2019
@wkcn
Copy link
Member

wkcn commented May 7, 2019

Merged. Thank you for the fix!

@anirudhacharya anirudhacharya deleted the stype branch May 7, 2019 23:24
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
@anirudhacharya
Fix the return type of sparse.clip operator (apache#14856)
5365eb8 
* stype fix

* ut

* retrigger ci

* Retrigger ci
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@anirudhacharya
Fix the return type of sparse.clip operator (apache#14856)
4e972e1 
* stype fix

* ut

* retrigger ci

* Retrigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nd.sparse.clip operation return type is different from the input
4 participants
@anirudhacharya @wkcn @eric-haibin-lin @marcoabreu