This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix Clojure BERT example's context argument #14843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused requires * Remove unused vars & function * Use `io` alias
The `infer` function accepts a CPU/GPU context, which the command line version of this example exposes as a `:cpu`/`:gpu` keyword. Previously, these options were ignored and the context was overridden to the default context (CPU). This commit allows users (both REPL and shell) to pass in a GPU context.
|
Thanks Carin. I had just seen your in-progress PR before this got merged. Sorry for not doing my due diligence and making my changes there. |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
* Clojure BERT example: minor code cleanup * Remove unused requires * Remove unused vars & function * Use `io` alias * Clojure BERT example: whitespace fix * Clojure BERT example: allow running with GPU The `infer` function accepts a CPU/GPU context, which the command line version of this example exposes as a `:cpu`/`:gpu` keyword. Previously, these options were ignored and the context was overridden to the default context (CPU). This commit allows users (both REPL and shell) to pass in a GPU context.
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Clojure BERT example: minor code cleanup * Remove unused requires * Remove unused vars & function * Use `io` alias * Clojure BERT example: whitespace fix * Clojure BERT example: allow running with GPU The `infer` function accepts a CPU/GPU context, which the command line version of this example exposes as a `:cpu`/`:gpu` keyword. Previously, these options were ignored and the context was overridden to the default context (CPU). This commit allows users (both REPL and shell) to pass in a GPU context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Clojure BERT example's
inferfunction accepts a CPU/GPU context, which the command lineversion of this example exposes as a
:cpu/:gpukeyword. Previously, these options were ignored and the context was always overridden to the default context (CPU). This PR allows users (both REPL and shell) to pass in a GPU context.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created(this is a tiny-change PR)Changes
Comments