Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Print reproduction command on CI failure #14815

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 26, 2019

Description

Prints the reproduction copy/paste command so going to the full output in Jenkins is not necessary thus easing life of developers reproducing CI failures.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@roywei
Copy link
Member

roywei commented Apr 29, 2019

Thanks for the contribution. @mxnet-label-bot add [CI]

@marcoabreu marcoabreu added the CI label Apr 29, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@larroy
Copy link
Contributor Author

larroy commented Apr 30, 2019

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Apr 30, 2019
@wkcn wkcn merged commit 381a9da into apache:master May 2, 2019
@wkcn
Copy link
Member

wkcn commented May 2, 2019

Merged. Thanks for your contribution!

access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants