Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix int64 nightly tests #14809

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix int64 nightly tests #14809

merged 1 commit into from
Apr 26, 2019

Conversation

edisongustavo
Copy link
Contributor

@edisongustavo edisongustavo commented Apr 26, 2019

The nightly tests are failing because no one is publishing this stash: http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/master/292/pipeline

From "Build / CPU: USE_INT64_TENSOR_SIZE", it publishes ubuntu_cpu_int64, when it should be cpu_int64

Description

The PR #14570 has introduced a bug where the "stash name" is not matching:

  • It is packed as ubuntu_cpu_int64
  • It is unpacked as cpu_int64

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

The PR #14570 has
introduced a bug where the "stash name" is not matching:

- It is **packed** as `ubuntu_cpu_int64`
- It is **unpacked** as `cpu_int64`
@edisongustavo
Copy link
Contributor Author

@marcoabreu

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Apr 26, 2019
@marcoabreu marcoabreu merged commit 680bade into apache:master Apr 26, 2019
@apeforest
Copy link
Contributor

@edisongustavo Thanks for fixing this error quickly

@edisongustavo edisongustavo deleted the fix-nightly-tests-for-int64 branch April 26, 2019 21:39
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
The PR apache#14570 has
introduced a bug where the "stash name" is not matching:

- It is **packed** as `ubuntu_cpu_int64`
- It is **unpacked** as `cpu_int64`
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
The PR apache#14570 has
introduced a bug where the "stash name" is not matching:

- It is **packed** as `ubuntu_cpu_int64`
- It is **unpacked** as `cpu_int64`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants