This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Scala/Java Predict API fix #14756 #14804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
approved these changes
Apr 25, 2019
piyushghai
reviewed
Apr 25, 2019
| @@ -264,7 +276,8 @@ abstract class BaseModule { | |||
| s"in mini-batches (${out.size})." + | |||
| "Maybe bucketing is used?") | |||
| ) | |||
| val concatenatedOutput = outputBatches.map(out => NDArray.concatenate(out)) | |||
| val oBT = outputBatches.transpose | |||
| val concatenatedOutput = oBT.map(out => NDArray.concatenate(out)) | |||
There was a problem hiding this comment.
Do you also need to dispose oBT here ?
There was a problem hiding this comment.
This create a soft copy, the content inside contains same reference
piyushghai
reviewed
Apr 25, 2019
scala-package/core/src/main/scala/org/apache/mxnet/module/BaseModule.scala
Outdated
Show resolved
Hide resolved
yzhliu
approved these changes
Apr 26, 2019
gigasquid
approved these changes
Apr 26, 2019
lanking520
force-pushed
the
java-predict-fix
branch
from
614ad53
to
93256ef
Compare
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 29, 2019
* add fix in the code * add unit test * update comments
lanking520
added a commit
that referenced
this pull request
Apr 29, 2019
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
* add fix in the code * add unit test * update comments
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add fix in the code * add unit test * update comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug are being identifed that the concatenation process applied on the predict is incorrect. This PR is a fix on that #14756.
@zachgk @gigasquid @yzhliu @androuino
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.