Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[clojure][generator] ndarray/symbol api random merged #14800

Merged

Conversation

Chouffe
Copy link
Contributor

@Chouffe Chouffe commented Apr 25, 2019

Reopened from PR #14750

Description

Split random functions in their own generated namespace.

  • ndarray_random_api
  • symbol_random_api

It renames the following functions to be as close as possible to the scala names:

  • -random-randint into randint
  • sample-randint into randint-likefor instance and put them under ndarray-random-api namespace.

TODO

  • Unify random and sample functions (mu vs loc and sigma)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Chouffe
Copy link
Contributor Author

Chouffe commented Apr 25, 2019

cc @kedarbellare

@Chouffe Chouffe changed the title Arthur/clojure ndarray api random merged [clojure][generator] ndarray/symbol api random merged Apr 25, 2019
@@ -0,0 +1,95 @@
(ns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have this file checked in? - it looks like it is written to during the generator test to compare contents

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooops! Good catch! I will remove them

@@ -0,0 +1,118 @@
(ns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question - Do we need to have this file checked in? - it looks like it is written to during the generator test to compare contents

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same answer! Ooooops!

@gigasquid
Copy link
Member

Overall looks fantastic! What a great addition :)

Just a couple questions on the inclusion of some test files

@gigasquid gigasquid merged commit 5dd9fa2 into apache:master Apr 26, 2019
@gigasquid
Copy link
Member

sorry merged by mistake

gigasquid added a commit that referenced this pull request Apr 26, 2019
@gigasquid
Copy link
Member

@Chouffe - Actually instead of reverting it, I'll just open a new PR with those two file removed, Since everything else is good

@Chouffe Chouffe deleted the arthur/clojure-ndarray-api-random-merged branch May 2, 2019 15:23
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
* [clojure][generator] add random namespace generation

* `ndarray_random_api`
* `symbol_random_api`

* fix tests
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* [clojure][generator] add random namespace generation

* `ndarray_random_api`
* `symbol_random_api`

* fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants