Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update MKL-DNN submodule to v0.19 #14783

Merged
merged 10 commits into from
May 16, 2019
Merged

Update MKL-DNN submodule to v0.19 #14783

merged 10 commits into from
May 16, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Apr 24, 2019

Description

This PR updates the MKL-DNN submodule to v0.19. Currently it's still a release candidate. Will update to the final release commit once it's released.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel pengzhao-intel mentioned this pull request Apr 24, 2019
Closed
@TaoLv TaoLv requested a review from anirudh2290 as a code owner April 24, 2019 14:51
@TaoLv
Copy link
Member Author

TaoLv commented Apr 25, 2019

Hi @iblis17, may I have you comments on the failure of Julia tests?

@iblislin
Copy link
Member

iblislin commented Apr 25, 2019 •
edited
Loading

Hi @TaoLv ,
please consider rebasing your PR, there is a related patch merged recently: #14776

@TaoLv
Copy link
Member Author

TaoLv commented Apr 25, 2019

Thank you @iblis17 . Will try!

@szha szha added this to In progress in CPU Performance and Quantization Apr 25, 2019
@TaoLv TaoLv mentioned this pull request Apr 27, 2019
Merged
7 tasks
@roywei
Copy link
Member

roywei commented Apr 29, 2019

@mxnet-label-bot add[MKLDNN, pr-work-in-progress]

@marcoabreu marcoabreu added MKLDNN pr-work-in-progress PR is still work in progress labels Apr 29, 2019
@TaoLv TaoLv requested a review from szha as a code owner May 8, 2019 02:35
@eric-haibin-lin
Copy link
Member

What's the pending item for this PR?

@TaoLv
Copy link
Member Author

TaoLv commented May 15, 2019

@eric-haibin-lin Finally MKL-DNN 0.19 was just released today. This PR is updated accordingly.

@TaoLv TaoLv changed the title [WIP] Update MKL-DNN submodule to v0.19 Update MKL-DNN submodule to v0.19 May 15, 2019
pengzhao-intel
pengzhao-intel approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's wait for the CI

CPU Performance and Quantization automation moved this from In progress to Reviewer approved May 15, 2019
@pengzhao-intel
Copy link
Contributor

@TaoLv please rebase the code since the TRT failure is disabled now.

@pengzhao-intel
Copy link
Contributor

Merging now, thanks for your contribution.

@pengzhao-intel pengzhao-intel merged commit eecf07a into apache:master May 16, 2019
CPU Performance and Quantization automation moved this from Reviewer approved to Done May 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@TaoLv
Update MKL-DNN submodule to v0.19 (apache#14783)
b734950 
* update to mkldnn v0.19-rc

* update cpp test

* update mklml library

* bump mkldnn version to v0.19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
MKLDNN pr-work-in-progress PR is still work in progress
Projects
No open projects
CPU Performance and Quantization
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TaoLv @iblislin @roywei @eric-haibin-lin @pengzhao-intel @marcoabreu