Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix GELU backward possible NaN #14782

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 24, 2019

Description

As title. Issue discovered by @eric-haibin-lin

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Get rid of division in backward kernel.

Comments

@haojin2 haojin2 self-assigned this Apr 24, 2019
@haojin2 haojin2 force-pushed the GELU_backward branch 4 times, most recently from ad60da9 to 36eb418 Compare April 24, 2019 19:56
@haojin2
Copy link
Contributor Author

haojin2 commented Apr 25, 2019

@eric-haibin-lin Ready for merge.

@eric-haibin-lin eric-haibin-lin merged commit 22377ed into apache:master Apr 25, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* fix gelu with erf functions

* fix possible NaN in GELU backward
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants