Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

data preparation file moved in example #14781

Merged
merged 3 commits into from
Apr 27, 2019
Merged

data preparation file moved in example #14781

merged 3 commits into from
Apr 27, 2019

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Apr 23, 2019

Description

Fixes #14736
Image_classification.py was not working as data preparation script was moved under specific super_resolution example.
Introduced in this PR: #14179

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini Roshrini requested a review from szha as a code owner April 23, 2019 23:25
@wkcn
Copy link
Member

wkcn commented Apr 23, 2019

super_resolution.py also imports data.py. Could we add an import path for it?

@Roshrini
Copy link
Member Author

@wkcn super_resolution.py is already using data.py from its parent directory. Code used:
"this_dir = path.abspath(path.dirname(file))
sys.path.append(path.join(this_dir, path.pardir))"

Tested by running super_resolution.py and image_classification.py successfully with this change.

@Roshrini Roshrini added the pr-awaiting-review PR is waiting for code review label Apr 24, 2019
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM

@wkcn wkcn merged commit 40e3d7c into apache:master Apr 27, 2019
@wkcn
Copy link
Member

wkcn commented Apr 27, 2019

The PR has been merged. Thank you!

@Roshrini Roshrini deleted the move-file branch April 29, 2019 06:41
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
* moved file

* Empty Commit

* Retrigger
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* moved file

* Empty Commit

* Retrigger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image classification example (/example/gluon): no module named data
3 participants