Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Deprecate NDArrayCollector and instead use ResourceScope #14780

Merged
merged 1 commit into from
May 11, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Apr 23, 2019

Description

This PR now removes all usages of NDArrayCollector throughout the code and deprecates it as of the 1.5.0 release.

It also updates the ResourceScope to recursively move NDArrays to outer scope when in hierarchical structure of Traversables (list, set, map, etc.) and Products (tuples). It adds a method to check if the ResourceScope contains a value and fixes a bug where moveToOuterScope would move a value to the outer scope despite it not being in the inner scope in the first place.

This contains additions originally part of #14666 that were split out.

@lanking520 @andrewfayres @nswamy

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk
Copy link
Contributor Author

zachgk commented Apr 23, 2019

@mxnet-label-bot add [Scala, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Apr 23, 2019
@vandanavk
Copy link
Contributor

@zachgk could you check the CI build?

@nswamy @lanking520 for your review

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 4796851 into apache:master May 11, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants