Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix acc_type_switch macro with extra tests #14773

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 23, 2019

Description

Fix the bug that reduction operators would not produce the correct value for integer type inputs due to bug in MXNET_ACC_TYPE_SWITCH.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix ACC_TYPE_SWITCH macro
  • Extra test for integer norm

Comments

@reminisce

@haojin2 haojin2 force-pushed the fix_ACC_TYPE_SWITCH branch 4 times, most recently from 335846b to a1e433d Compare April 23, 2019 19:40
@haojin2
Copy link
Contributor Author

haojin2 commented Apr 23, 2019

@reminisce reminisce merged commit 2fd4720 into apache:master Apr 24, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants