Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable USE_GPERFTOOLS by default #14711

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

ZhennanQin
Copy link
Contributor

@ZhennanQin ZhennanQin commented Apr 16, 2019

Description

Because of #8968, mxnet will random crash after USE_GPERFTOOLS = 1. Some end-user may get trouble if gperf-tools is pre-installed. So before fix this, we'd better to disable it by default.

@pengzhao-intel @szha

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ZhennanQin ZhennanQin requested a review from szha as a code owner April 16, 2019 08:36
@pengzhao-intel
Copy link
Contributor

@szha @eric-haibin-lin is there any reason that the gperf is ON by default?
Our customer encountered the crash w/ gperf ON, so we prefer to make it OFF by default.

@pengzhao-intel
Copy link
Contributor

cc @lebeg

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also met the issue about GPERFTOOLS.

@Roshrini Roshrini added CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review labels Apr 16, 2019
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will merge in 24 hours if there are no further comments :)

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was decided by an individual as there is significant performance benefit in using alternative malloc. It wasn't thoroughly evaluated and I actually noticed similar issues with tcmalloc, so I'm actually surprised that this is on by default in cmake.

@pengzhao-intel
Copy link
Contributor

Merging now since the BOSS agree :)

@pengzhao-intel pengzhao-intel merged commit a26ad37 into apache:master Apr 17, 2019
@anirudh2290
Copy link
Member

I guess it was decided by an individual as there is significant performance benefit in using alternative malloc. It wasn't thoroughly evaluated and I actually noticed similar issues with tcmalloc, so I'm actually surprised that this is on by default in cmake.

An "individual" by himself/herself cannot make decisions in an apache incubating project.

@cjolivier01
Copy link
Member

cjolivier01 commented Apr 17, 2019

Interesting theory szha, although also incorrect. But disable if you want. Jemalloc is faster most of the time anyway.

@szha
Copy link
Member

szha commented Apr 17, 2019

@cjolivier01 thanks for stepping in. I'd like to hear what you would like clairfy and what option you recommend?

kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
@ZhennanQin ZhennanQin deleted the tcmalloc branch May 31, 2019 02:07
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants