Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix spelling in threaded_engine_test #14709

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Fix spelling in threaded_engine_test #14709

merged 1 commit into from
Apr 17, 2019

Conversation

KellenSunderland
Copy link
Contributor

Description

Fixed a few spelling mistakes before adding a test.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

anirudh2290
anirudh2290 reviewed Apr 16, 2019
View reviewed changes
tests/cpp/engine/threaded_engine_test.cc Outdated
} else {
auto func = [wl, data](RunContext ctx, Engine::CallbackOnComplete cb) {
EvaluateWorload(wl, data); cb();
EvaluateWorkload(wl, data); cb();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasnt the indentation correct ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Fixed, rebased and pushed.

@Roshrini Roshrini added the pr-awaiting-response PR is reviewed and waiting for contributor to respond label Apr 16, 2019
@KellenSunderland KellenSunderland removed the pr-awaiting-response PR is reviewed and waiting for contributor to respond label Apr 17, 2019
@Roshrini Roshrini added the pr-awaiting-review PR is waiting for code review label Apr 17, 2019
@KellenSunderland KellenSunderland merged commit 42e929b into apache:master Apr 17, 2019
kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
@KellenSunderland @kedarbellare
Fix spelling in threaded_engine_test (apache#14709)
3964144
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@KellenSunderland
Fix spelling in threaded_engine_test (apache#14709)
284aa41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 anirudh2290 left review comments

@Roshrini Roshrini Roshrini approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KellenSunderland @anirudh2290 @Roshrini