This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Set idx2name for Optimizer object #14703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptrendx @romerojosh @apeforest @eric-haibin-lin Please help review. @mxnet-label-bot add [pr-awaiting-review] |
|
Great! It solves the issue #9511. |
Not sure if there is any. If not, I can add one. Let me check. |
|
@eric-haibin-lin Added unit test. Can you help review and merge? |
eric-haibin-lin
approved these changes
Apr 18, 2019
|
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
|
Merged. Thank you! |
kedarbellare
pushed a commit
to kedarbellare/incubator-mxnet
that referenced
this pull request
Apr 20, 2019
* set idx2name for optimizer * add unit test
yuxihu
added a commit
to yuxihu/incubator-mxnet
that referenced
this pull request
Apr 22, 2019
* set idx2name for optimizer * add unit test
szha
pushed a commit
that referenced
this pull request
Apr 23, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* set idx2name for optimizer * add unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we use
module.fit(), we can pass a str or an Optimizer object as the optimizer. When we pass an Optimizer object that is created outside before callingmodule.fit(), we are not checking and settingoptimizer.idx2namewhich is used to mask out entries in update for weight decay in module.init_optimizer method. Ifidx2nameis not set when creating the optimizer object outside, it can impact the convergence behavior as weight decay is applied to all parameters in this case.This PR checks if
idx2nameis set if an Optimizer object is given. If not, we are setting it to the proper values. Fixes #9511 as @wkcn pointed out.