Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1287] Up scala comp #14667

Merged
merged 4 commits into from
Apr 11, 2019
Merged

[MXNET-1287] Up scala comp #14667

merged 4 commits into from
Apr 11, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Apr 10, 2019

Description

This PR contains a number of improvements to the Maven configuration. Most notably, it switches to a set of dependencies all using Scala version 2.11.8 and upgrading the Scala compiler plugin from the deprecated scala-maven-plugin to the current maven-scala-plugin. Contains a part of #13995.

@lanking520 @andrewfayres

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk
Copy link
Contributor Author

zachgk commented Apr 10, 2019

@mxnet-label-bot add [Scala, Maven, pr-awaiting-review]

@marcoabreu marcoabreu added Maven pr-awaiting-review PR is waiting for code review Scala labels Apr 10, 2019
@zachgk zachgk mentioned this pull request Apr 10, 2019
12 tasks
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one good to me too..

@lanking520 lanking520 merged commit 26b14bc into apache:master Apr 11, 2019
@zachgk zachgk deleted the upScalaComp branch April 12, 2019 22:18
larroy pushed a commit to larroy/mxnet that referenced this pull request Apr 15, 2019
* Upgrade scala compiler

* Fix scala version mismatch

* Fix no source root warnings

* Misc compiler fixes
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Upgrade scala compiler

* Fix scala version mismatch

* Fix no source root warnings

* Misc compiler fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Maven pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants