Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Safer norm #14616

Merged
merged 6 commits into from
Apr 15, 2019
Merged

Safer norm #14616

merged 6 commits into from
Apr 15, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 4, 2019

Description

Resurrection of #14240 to solve #14126. With an extra argument of norm for specification of output data type.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@szha
Unit test passed 10000 times on GPU:

MXNET_TEST_COUNT=10000 nosetests tests/python/gpu/test_operator_gpu.py:test_norm
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=19910248 to reproduce.
.
----------------------------------------------------------------------
Ran 1 test in 234.244s

OK

@haojin2 haojin2 requested a review from szha April 4, 2019 07:08
@szha
Copy link
Member

szha commented Apr 4, 2019

cc @ptrendx

@piyushghai
Copy link
Contributor

Thanks for your contributions @haojin2. Can you also look into the CI failures ?

@mxnet-label-bot Add [Operator, Backend]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet Operator labels Apr 4, 2019
@haojin2 haojin2 force-pushed the safe_norm branch 2 times, most recently from 15f00ef to 884b7a3 Compare April 9, 2019 20:32
@haojin2
Copy link
Contributor Author

haojin2 commented Apr 9, 2019

@eric-haibin-lin

@haojin2 haojin2 force-pushed the safe_norm branch 12 times, most recently from bb297b8 to 04cda68 Compare April 11, 2019 21:02
@eric-haibin-lin eric-haibin-lin merged commit b3b952f into apache:master Apr 15, 2019
@sxjscience sxjscience mentioned this pull request Apr 15, 2019
6 tasks
kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
* use safe aggregation for norm

* safe norm with DataType, AccuType and OutType

* new test for backward

* change back to MSHADOW_TYPE_SWITCH

* remove dead debug outputs

* Allow integer types
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* use safe aggregation for norm

* safe norm with DataType, AccuType and OutType

* new test for backward

* change back to MSHADOW_TYPE_SWITCH

* remove dead debug outputs

* Allow integer types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants