Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt #14599

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt #14599

merged 2 commits into from
Apr 30, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 2, 2019

Description

This will have the effect to provide stack traces on crashes by default in CMake based builds

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy requested a review from szha as a code owner April 2, 2019 20:31
@piyushghai
Copy link
Contributor

@mxnet-label-bot Add [CMake, pr-awaiting-review]

@marcoabreu marcoabreu added CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review labels Apr 2, 2019
@Roshrini
Copy link
Member

@marcoabreu @anirudh2290 Can you please help review?

roywei
roywei approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@szha szha merged commit 3a46980 into apache:master Apr 30, 2019
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
@larroy
Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt (apache…
7ff204c 
…#14599)

* Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt

* Fix lint error with NULL vs nullptr
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@larroy
Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt (apache…
063ff2a 
…#14599)

* Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt

* Fix lint error with NULL vs nullptr
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roywei roywei roywei approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@larroy @piyushghai @Roshrini @roywei @szha @marcoabreu