This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Set _scale in Trainer using Optimizer rescale_grad #14593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good catch @yuxihu. @mxnet-label-bot Add [Gluon, pr-awaiting-review] |
|
@eric-haibin-lin @apeforest Please help review. |
eric-haibin-lin
approved these changes
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
_scaleis set based on the value of rescale_grad in optimizer_params when creating Trainer. However, users can use optimizer_params to create an Optimizer object and pass this object to Trainer. In this case,_scalemay not be correctly set since optimizer_params is None.In this PR, we set
_scaleby reading the rescale_grad value from optimizer after optimizer is initialized in Trainer.