Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixing example README to keep it consistent with the changes that went in #14573

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

vdantu
Copy link
Contributor

@vdantu vdantu commented Mar 31, 2019

Description

(Brief description on what this PR is about)
The "python-howto" was removed in a previous commit "3e8a976d805dee130831d4f54b7a5dd9f1a7c7bd". The reference to this folder wasn't removed from the README file. Removed the reference in this PR.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vdantu vdantu requested a review from szha as a code owner March 31, 2019 04:11
@vdantu
Copy link
Contributor Author

vdantu commented Mar 31, 2019

@ThomasDelteil : Could you please let me know if this is the right fix?

@mxnet-label-bot add [Doc, Example]

fixes #14572

@piyushghai
Copy link
Contributor

@vdantu Can you re-trigger the CI with an empty commit ?

…ce to that folder was not removed. Making a PR to remove the reference to this folder to keep documents consistent
@ThomasDelteil ThomasDelteil merged commit 9dda62f into apache:master Apr 8, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…ce to that folder was not removed. Making a PR to remove the reference to this folder to keep documents consistent (apache#14573)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants